 |
IgorB: not sure I clarified that the request for a possible percentage option with Masking is now part of issue 212. The priority could be affected by issue 25 if Scaling for 4K monitors shows GG the necessity for masking percentage (an inexpensive 4K monitor is now available for GG to work on 25 in the near future). |
|
|
(I updated issue 0000212 to include this previous note by IgorB so that it does not get lost when the title of this issue is closed.) A "heated" discussion here on 08-05 about using percentage with the end result being that MAYBE a future choice can be added to use percentage as an alternative option. Below is some of the discussion points in favor of using pixels and NOT percentage. The slider is 205 pixels across so if you were to make it percentage instead, then 25% of 2000 is 500 instead of the current 100, so that every pixel on canvas represents several pixels. You would not get the daintiness of precision. Initially the reason for 100 is it was getting much slower with larger numbers. With the Masking mod checked in today, the almost painfully slow drawing of the masks has been alleviated for numbers larger than 100. OpenGL driver is provably faster on at least our desktop and laptop than the X11 software driver. A test version for Ubuntu16 containing the mask feathering changes as previously designed and now with speedups is at: https://www.cinelerra-gg.org/download/testing/cinelerra-5.1-ub16-x86_64-static.txz It contains the upgrade to FFmpeg 4.2 also. |
 |
I just tested this and in a case a dump, without generated file, is occur. Probably my old PC is poor. Sorry, I understand the sticky spot in the middle, but sticky spot at the end and start, I don’t like. My personal taste, of course. And I ask you, why don’t use percent unit instead of pixels unit (like I wrote in 0000212), like other NLEs do? So it would not be affected by the project format, and if an users uses Proxy without scaler. And if another hyperformat (16K) comes out the tool always works, I think. As an example consider that Feather goes from -100% to +100%, and +100% is the max positive Feather=Project width format (or what you think more appropriate). So if I insert Feather(%)= 2.5 you have: - format project 1080p ==> Feather(px)= 1080*2.5/100= 27 pixels - format project UltraHD 3840x2160 ==> Feather(px)= 2160*2.5/100= 54 pixels - format project 8k 7680x4320 ==> Feather(px)= 4320*2.5/100= 108 pixels - Proxy without scaler 480x270 ==> Feather(px)= 270*2.5/100= 6.75 pixels => 7 pixels So you can change the project format and what you see on Compositor is always the same Feather (size of feather), I think. |
|
|
The latest GIT checkin includes 2 changes: 1 - feathering algorithm is gaussian, and looks very much like the original Mask implementation so not so "linear". 2 - in order to get more than 100 pixels on the slider bar for feathering, a novel approach was implemented which does not have to be used by those preferring the faster 100 pixel limitation. Just let me warn you, that mask updates will be quite slow when using much more than about 200 pixels if using the X11 driver. The OpenGL driver is reasonable and runs at an acceptable speed (watch the red diamond-shaped box in the lower right hand side of the compositor screen). So here is how it works. There is a sticky spot at 100 (and all of this is true in the negative direction also). Then when you click on the slider diamond-shaped button at 100 and move quickly right, you will see that button jump back on the slider bar in order to provide more slider room to use a bigger number past 100. It is kind of fun to watch! For other masks or to get back to the more reasonable sticky 100, move the slider below 100, then click on the top "Protect Video" tool in the Compositor window and this should reset to 100 when you click on the Masking tool again. There is an ubuntu16/17/18 build if anyone wants to test: https://www.cinelerra-gg.org/download/testing/cinelerra-5.1-ub16-x86_64-static.txz https://www.cinelerra-gg.org/download/testing/cinelerra-5.1-ub17-x86_64-static.txz https://www.cinelerra-gg.org/download/testing/cinelerra-5.1-ub18-x86_64-static.txz |
- Anonymous
