View Issue Details

IDProjectCategoryView StatusLast Update
0000539Cinelerra-GG[All Projects] Bugpublic2021-01-27 19:10
ReporterRafaMar Assigned ToPhyllisSmith  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000539: Problems with some keyboard shortcuts
DescriptionNext auto 'Alt-a’ Move to next auto (ok, It works perfect)

but
Prev auto 'Ctrl-Alt-a’ Move to previous auto
Next auto select 'Alt-Shift-A’ Select from cursor to next auto
Prev auto select 'Ctrl-Alt-Shf-A’ Select from cursor to previous auto

They don't work well ... I notice that 'Ctrl-Alt-a' now selects the clip or clips that are under the cursor.
I have reviewed the shortcuts in the app's help and they still make reference to moving between keyframes.
TagsNo tags attached.

Activities

PhyllisSmith

PhyllisSmith

2021-01-27 19:10

manager   ~0004602

Closing as is fixed in current GIT.
PhyllisSmith

PhyllisSmith

2021-01-22 03:30

manager   ~0004560

@RafaMar
In the past, I mark these Resolved (after new builds are available for users to download) and then Closed a few days later.
But since closing was requested, I will do so.
RafaMar

RafaMar

2021-01-19 17:29

reporter   ~0004551

@PhyllisSmith
I remember this issue, but I just tested that it is resolved in the cinelerra-09fd138.tar.gz version of 2021-01-18 and the shortcuts work perfectly again.
Thank you.
RafaMar

RafaMar

2020-12-01 13:13

reporter   ~0004399

@IgorBeg wow I think your proposal is great, much, much better than my idea of a floating window just for this.
What you propose would be great and I suppose that for someone who masters programming it would be easy to implement.
It would be of great help and together with the shift key it would make selections between keyframes much easier.
Thank you very much for your contribution and please do not apologize for your previous comment, especially when your clear intention is to help.
IgorBeg

IgorBeg

2020-12-01 12:47

reporter   ~0004398

RafaMar wrote:
Yes, I know these accesses and their way of selecting, some time ago I did a tutorial in Spanish on this topic of selections.

Sorry for that.

RafaMar, I saw your "Navigate window small.png". Time ago (I don't remember where and when, maybe around August 2019), in some discussion with Sam and Phyllis I suggested another way on Overlay window. I added the photomontage. Anyway, fortunately, We can use the shortcuts.

RafaMar

RafaMar

2020-11-30 17:45

reporter   ~0004397

@Andrea_Paz Thanks, I was unaware that it had already been tried to compile in these formats. As I have mentioned before, I have no knowledge to help. The only thing I could do is try.
Andrea_Paz

Andrea_Paz

2020-11-30 16:19

manager   ~0004396

Flatpak:
An attempt has been made with "appimagemage"; see BT=0261
RafaMar

RafaMar

2020-11-30 14:46

reporter   ~0004395

Hi @PhyllisSmith. After the sad events it is logical that for now there are no updates until a solution is found. It is totally understandable.

I know that some time ago we talked about making a single flatpak version for all Gnu/Linux distributions. I think they all support this format. I tried to document myself to see if I could help with this... but I realized that I could not and I did not tell you anything more about it, because I saw that my knowledge is not enough to help create a Flatpak version of Cinelerra GG. If I bring up the subject again today, it is because I think it would save work to make a single compilation for all from GIT and in this way updates could be sent when necessary or when there was a correction or novelty. I do not know if as usual I am saying nonsense, but it is to try to help as much as possible.
RafaMar

RafaMar

2020-11-30 14:32

reporter   ~0004394

Thank you very much @IgorBeg.
Yes, I know these accesses and their way of selecting, some time ago I did a tutorial in Spanish on this topic of selections. For this reason, when working at Cinelerra and observing that the aforementioned accesses had stopped working, I made the ticket.
I know that due to the sad accident that deprived us of the person who was in charge of keeping Cinelerra up to date, we are going through a bad time to make new suggestions and I try to be cautious with them.
What I was proposing was a floating window, like the one in "Show Overlays" but focused on the selections. I think it would be something that would facilitate editing and we would not have to remember so many key combinations, which on the other hand it is good to keep the classic ones that appear in the manual so as not to create conflict with the users who make use of them. (As long as possible)

Navigate window small.png (14,082 bytes)
Navigate window small.png (14,082 bytes)
IgorBeg

IgorBeg

2020-11-30 13:02

reporter   ~0004393

Thank you so much, @PhyllisSmith !

I want to point out that my suggestion about to use the " Ctrl + Alt + single quote" was because I thought that as Italian and US keyboards have the "single quote" character, also UK, Spanish and French have it; I don't know for the other keyboards as Russian (@Andrew-R).

Note (about @RafaMar 0004385) :
I think You always know. In Main window, in the Transport & Buttons bar.
You can highlight an area in timeline using the Shift key and "Previous edit"/"Next edit" or "Previous label"/"Next label" icon:
- If you hold down Shift key and click on the "Previous edit" or "Next edit" icon, then the area is highlighted from Insertion Point to Previous/Next edit.
- If you hold down Shift key and click on the "Previous label" or "Next label" icon, then the area is highlighted from Insertion Point to Previous/Next label.

About monthly builds, I don't know if it has sense for You, but I could make a static-build for the Ubuntu_16.04 users. And maybe other users, on different Operating System, could make a static-build for users that are not able to do it.
Keep in mind I am really ignorant about Linux (and so on).
Unfortunately I have to use this "configure" on my system:
<code>./configure --with-single-user --without-shuttle-usb --without-vaapi --without-vdpau --disable-dav1d</code>
Andrew-R

Andrew-R

2020-11-30 01:07

reporter   ~0004392

cool, thanks!
PhyllisSmith

PhyllisSmith

2020-11-29 20:38

manager   ~0004391

@Andrew-R
An Anonymous Contributor provided a patch that put the code back to the way it was originally. So now the keyframe movement shortcuts work as documented. "Select Edits", shown using the Middle Mouse Button on the track now has a shortcut of Ctrl-Alt-' where ' is a single quote.

This has been checked into GIT just now, BUT there will not be any automatic provided monthly builds for some undetermined amount of time so only people who build Cinelerra-GG on their own will get the corrections/improvements.
Andrew-R

Andrew-R

2020-11-28 17:23

reporter   ~0004388

Also, a bit of trivia: it seems there was specialized keyboard before IBM PC, called 'Space-cadet':
https://en.wikipedia.org/wiki/Space-cadet_keyboard
----
Four bucky keys: Ctrl, Meta, Super, and Hyper.
----

Guess CinGG can make some use of those for now :} (I mean, whole 'add A feature' apparently hit limit on how many actions you can tie to single key ...with just three modifiers. Ctrl - and Shift- already taken for 'reverse' and 'select' in our context). So bad normal keyboards still few keys short in this department .....
Andrew-R

Andrew-R

2020-11-28 12:29

reporter   ~0004386

another note, I use ru/us keyboard, so selection to prev auto doesn't work with my patch.
still, I can clear just xkb options:

setxkbmap "us,ru" ",winkeys" "grp:ctrl_shift_toggle" -option

and then cin will work as intended.

Afterwards I can switch this option back on:
 setxkbmap "us,ru" ",winkeys" "grp:ctrl_shift_toggle"

Note, with this patch 'deselect group' become ctrl-shift-a!
I haven't updated shortcuts.html because not sure how this patch will be received (I get all your suggestions, just implementing them will be non-trivial task for me - this patch more like band-aid so functionality will work again)
RafaMar

RafaMar

2020-11-28 11:05

reporter   ~0004385

Thank you very much @Andrew-R
It would be preferable to keep the classic accesses, which are the ones that users have memorized. As long as possible.

I would like to make a proposal that has occurred to me, although I am aware that ignoring how application programming works may be silly.

A floating window for navigation and selections would be possible, something like:
------------------------------------------------------------------------------------------
Navigate Window
Effects Keyframes: ← → - Select: ← →
Line keyframes: ← → - Select: ← →
Labels: ← → - Select: ← →
Clips: ← → - Select: ← →
The selection will be made from the position of the playhead.
---------------------------------------------------------------------------------------------
(where the arrows are buttons)

A floating window that the user can open and close at any time from the window menu, or from the timeline icons.

If I knew about programming I would try to do it, but I am sorry I cannot help in this regard. I can only propose and assume that this may not be possible. Since keyboard shortcuts that are rarely used are often forgotten, this would greatly facilitate the work in Cinelerra when we must make modifications to a project. This window could have a help text indicating the key combinations.
Andrew-R

Andrew-R

2020-11-28 10:35

reporter   ~0004384

Sadly, I don't think you can make such shortcut-rich program conflict-less.But at least those DE have their own gui for keyboard settings (I hope). CinGG still doesn't have one.

I messed up my patch, ver.3 should work

alt+win+a = next auto
alt+win+a+ctrl = prev auto
alt+win+shift+a = select to next auto
alt+win+shift+ctrl+a = select to prev auto

ctrl-alt-shift-a toggles select/deselect group.

WINKEY-3.patch (4,216 bytes)
diff --git a/cinelerra-5.1/cinelerra/editpopup.C b/cinelerra-5.1/cinelerra/editpopup.C
index b1fef22f..96e08c6c 100644
--- a/cinelerra-5.1/cinelerra/editpopup.C
+++ b/cinelerra-5.1/cinelerra/editpopup.C
@@ -147,7 +147,7 @@ int EditPopupOpenEDL::handle_event()
 }
 
 EditPopupClearSelect::EditPopupClearSelect(MWindow *mwindow, EditPopup *popup)
- : BC_MenuItem(_("Clear Select"),_("Ctrl-Shift-A"),'A')
+ : BC_MenuItem(_("Clear Select"),_("Ctrl-Alt-Shift-A"),'A')
 {
 	this->mwindow = mwindow;
 	this->popup = popup;
@@ -162,7 +162,7 @@ int EditPopupClearSelect::handle_event()
 }
 
 EditPopupSelectEdits::EditPopupSelectEdits(MWindow *mwindow, EditPopup *popup)
- : BC_MenuItem(_("Select Edits"),_("Ctrl-Alt-a"),'a')
+ : BC_MenuItem(_("Select Edits"),_("Ctrl-Alt-Shift-a"),'a')
 {
 	this->mwindow = mwindow;
 	this->popup = popup;
diff --git a/cinelerra-5.1/cinelerra/mwindowgui.C b/cinelerra-5.1/cinelerra/mwindowgui.C
index 6381fa07..50469ac9 100644
--- a/cinelerra-5.1/cinelerra/mwindowgui.C
+++ b/cinelerra-5.1/cinelerra/mwindowgui.C
@@ -1090,20 +1090,19 @@ int MWindowGUI::keypress_event()
 
 	switch( get_keypress() ) {
 	case 'A':
-		if( !alt_down() && ctrl_down() ) {
+		if( !alt_down() && ctrl_down() && !winkey_down() && !shift_down()) {
 			mwindow->edl->tracks->clear_selected_edits();
 			draw_overlays(1);
 			result = 1;
 		}
-		break;
 	case 'a':
-		if( !ctrl_down() && alt_down() ) {
+		if( alt_down() && winkey_down())  {
 			stop_transport("MWindowGUI::keypress_event 1");
 			mwindow->nearest_auto_keyframe(shift_down(),
 				!ctrl_down() ? PLAY_FORWARD : PLAY_REVERSE);
 			result = 1;
 		}
-		else if( ctrl_down() && alt_down() ) {
+		else if( ctrl_down() && alt_down() && !winkey_down()) {
 			mwindow->select_edits(1);
 			result = 1;
 		}
@@ -1115,7 +1114,7 @@ int MWindowGUI::keypress_event()
 		result = 1;
 		break;
 
-	case 'k': case 'K':
+	case 'k': case 'K': 
 		if( alt_down() ) break;
 		stop_transport("MWindowGUI::keypress_event 2");
 		mwindow->nearest_plugin_keyframe(shift_down(),
diff --git a/cinelerra-5.1/guicast/bcwindowbase.C b/cinelerra-5.1/guicast/bcwindowbase.C
index 9f3e2123..93cdf15b 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.C
+++ b/cinelerra-5.1/guicast/bcwindowbase.C
@@ -274,7 +274,7 @@ int BC_WindowBase::initialize()
 	motion_events = 0;
 	resize_events = 0;
 	translation_events = 0;
-	ctrl_mask = shift_mask = alt_mask = 0;
+	ctrl_mask = shift_mask = alt_mask = winkey_mask = 0;
 	cursor_x = cursor_y = button_number = 0;
 	button_down = 0;
 	button_pressed = 0;
@@ -764,6 +764,7 @@ int BC_WindowBase::get_key_masks(unsigned int key_state)
 	ctrl_mask = (key_state & ControlMask) ? 1 : 0;  // ctrl key down
 	shift_mask = (key_state & ShiftMask) ? 1 : 0;   // shift key down
 	alt_mask = (key_state & Mod1Mask) ? 1 : 0;      // alt key down
+	winkey_mask = (key_state & Mod4Mask) ? 1 : 0;      // windows key down
 	return 0;
 }
 
@@ -4071,6 +4072,11 @@ int BC_WindowBase::ctrl_down()
 	return top_level->ctrl_mask;
 }
 
+int BC_WindowBase::winkey_down()
+{
+	return top_level->winkey_mask;
+}
+
 wchr_t* BC_WindowBase::get_wkeystring(int *length)
 {
 	if(length)
diff --git a/cinelerra-5.1/guicast/bcwindowbase.h b/cinelerra-5.1/guicast/bcwindowbase.h
index e4eb8ba4..c682d2cc 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.h
+++ b/cinelerra-5.1/guicast/bcwindowbase.h
@@ -347,6 +347,7 @@ public:
 	int alt_down();
 	int shift_down();
 	int ctrl_down();
+	int winkey_down();
 	int get_double_click();
 	int get_triple_click();
 // Bottom right corner
@@ -728,7 +729,7 @@ private:
 // key data
 	KeySym keysym;
 // Key masks
-	int ctrl_mask, shift_mask, alt_mask;
+	int ctrl_mask, shift_mask, alt_mask, winkey_mask;
 // Cursor motion information
 	int cursor_x, cursor_y;
 // Button status information
diff --git a/cinelerra-5.1/guicast/bcwindowbase.inc b/cinelerra-5.1/guicast/bcwindowbase.inc
index 046e7dd8..87bebace 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.inc
+++ b/cinelerra-5.1/guicast/bcwindowbase.inc
@@ -27,7 +27,7 @@ class BC_WindowBase;
 class BC_WindowList;
 class Shuttle;
 
-#define BCTEXTLEN 1024
+#define BCTEXTLEN 1536
 #define BCSTRLEN 64
 #define KEYPRESSLEN 6
 // Milliseconds before cursor disappears during video playback
WINKEY-3.patch (4,216 bytes)
RafaMar

RafaMar

2020-11-28 08:00

reporter   ~0004382

@IgorBeg First of all, thanks for the suggestion and interest.
The shortcuts you propose:
Ctrl + Alt + Shift + RightArrow
Ctrl + Alt + Shift + LeftArrow
They are shortcuts that most Linux distributions use to move the active window to a new workspace. Which can cause a conflict with the desktop environment shortcut.
I am in favor of keeping, whenever possible, the shortcuts proposed in the manual and which are the ones that users have learned.

@Andrew-R Thank you very much for the help, although I admit that I have not understood anything because I do not know the syntax of the programming language. :-) But I'm sure it will be very useful for those who do understand programming to solve the problem.
Andrew-R

Andrew-R

2020-11-28 07:58

reporter   ~0004381

Actually, I added back those 'select edits' and 'clear selected edits' case and it still work (I think). But I still don't know how those functions supposedt to work. Anyone who know?

Updated patch attached

WINKEY-2.patch (2,968 bytes)
diff --git a/cinelerra-5.1/cinelerra/mwindowgui.C b/cinelerra-5.1/cinelerra/mwindowgui.C
index 6381fa07..94720970 100644
--- a/cinelerra-5.1/cinelerra/mwindowgui.C
+++ b/cinelerra-5.1/cinelerra/mwindowgui.C
@@ -1097,7 +1097,7 @@ int MWindowGUI::keypress_event()
 		}
 		break;
 	case 'a':
-		if( !ctrl_down() && alt_down() ) {
+		if( ctrl_down && winkey_down() ) {
 			stop_transport("MWindowGUI::keypress_event 1");
 			mwindow->nearest_auto_keyframe(shift_down(),
 				!ctrl_down() ? PLAY_FORWARD : PLAY_REVERSE);
@@ -1115,7 +1115,7 @@ int MWindowGUI::keypress_event()
 		result = 1;
 		break;
 
-	case 'k': case 'K':
+	case 'k': case 'K': 
 		if( alt_down() ) break;
 		stop_transport("MWindowGUI::keypress_event 2");
 		mwindow->nearest_plugin_keyframe(shift_down(),
diff --git a/cinelerra-5.1/guicast/bcwindowbase.C b/cinelerra-5.1/guicast/bcwindowbase.C
index 9f3e2123..93cdf15b 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.C
+++ b/cinelerra-5.1/guicast/bcwindowbase.C
@@ -274,7 +274,7 @@ int BC_WindowBase::initialize()
 	motion_events = 0;
 	resize_events = 0;
 	translation_events = 0;
-	ctrl_mask = shift_mask = alt_mask = 0;
+	ctrl_mask = shift_mask = alt_mask = winkey_mask = 0;
 	cursor_x = cursor_y = button_number = 0;
 	button_down = 0;
 	button_pressed = 0;
@@ -764,6 +764,7 @@ int BC_WindowBase::get_key_masks(unsigned int key_state)
 	ctrl_mask = (key_state & ControlMask) ? 1 : 0;  // ctrl key down
 	shift_mask = (key_state & ShiftMask) ? 1 : 0;   // shift key down
 	alt_mask = (key_state & Mod1Mask) ? 1 : 0;      // alt key down
+	winkey_mask = (key_state & Mod4Mask) ? 1 : 0;      // windows key down
 	return 0;
 }
 
@@ -4071,6 +4072,11 @@ int BC_WindowBase::ctrl_down()
 	return top_level->ctrl_mask;
 }
 
+int BC_WindowBase::winkey_down()
+{
+	return top_level->winkey_mask;
+}
+
 wchr_t* BC_WindowBase::get_wkeystring(int *length)
 {
 	if(length)
diff --git a/cinelerra-5.1/guicast/bcwindowbase.h b/cinelerra-5.1/guicast/bcwindowbase.h
index e4eb8ba4..c682d2cc 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.h
+++ b/cinelerra-5.1/guicast/bcwindowbase.h
@@ -347,6 +347,7 @@ public:
 	int alt_down();
 	int shift_down();
 	int ctrl_down();
+	int winkey_down();
 	int get_double_click();
 	int get_triple_click();
 // Bottom right corner
@@ -728,7 +729,7 @@ private:
 // key data
 	KeySym keysym;
 // Key masks
-	int ctrl_mask, shift_mask, alt_mask;
+	int ctrl_mask, shift_mask, alt_mask, winkey_mask;
 // Cursor motion information
 	int cursor_x, cursor_y;
 // Button status information
diff --git a/cinelerra-5.1/guicast/bcwindowbase.inc b/cinelerra-5.1/guicast/bcwindowbase.inc
index 046e7dd8..87bebace 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.inc
+++ b/cinelerra-5.1/guicast/bcwindowbase.inc
@@ -27,7 +27,7 @@ class BC_WindowBase;
 class BC_WindowList;
 class Shuttle;
 
-#define BCTEXTLEN 1024
+#define BCTEXTLEN 1536
 #define BCSTRLEN 64
 #define KEYPRESSLEN 6
 // Milliseconds before cursor disappears during video playback
WINKEY-2.patch (2,968 bytes)
Andrew-R

Andrew-R

2020-11-28 07:52

reporter   ~0004380

so, it was more complicated that I thought, poor 'a' key SO overloaded ....
I added sense for 'Win' key and now it seems to work for simple case of 'go to prev/next auto' and 'select to next/prev' (I killed temporarily select edits and clear selected edits)

win+alt+a = next auto
win+alt+ctrl+a = prev auto
same + shift = select to next/prev auto

WINKEY.patch (3,531 bytes)
diff --git a/cinelerra-5.1/cinelerra/mwindowgui.C b/cinelerra-5.1/cinelerra/mwindowgui.C
index 6381fa07..b8b601bf 100644
--- a/cinelerra-5.1/cinelerra/mwindowgui.C
+++ b/cinelerra-5.1/cinelerra/mwindowgui.C
@@ -1090,23 +1090,23 @@ int MWindowGUI::keypress_event()
 
 	switch( get_keypress() ) {
 	case 'A':
-		if( !alt_down() && ctrl_down() ) {
-			mwindow->edl->tracks->clear_selected_edits();
-			draw_overlays(1);
-			result = 1;
-		}
-		break;
+//		if( !alt_down() && ctrl_down() ) {
+//			mwindow->edl->tracks->clear_selected_edits();
+//			draw_overlays(1);
+//			result = 1;
+//		}
+//		break;
 	case 'a':
-		if( !ctrl_down() && alt_down() ) {
+		if( ctrl_down && winkey_down() ) {
 			stop_transport("MWindowGUI::keypress_event 1");
 			mwindow->nearest_auto_keyframe(shift_down(),
 				!ctrl_down() ? PLAY_FORWARD : PLAY_REVERSE);
 			result = 1;
 		}
-		else if( ctrl_down() && alt_down() ) {
-			mwindow->select_edits(1);
-			result = 1;
-		}
+//		else if( ctrl_down() && alt_down() ) {
+//			mwindow->select_edits(1);
+//			result = 1;
+//		}
 		break;
 
 	case 'e':
@@ -1115,7 +1115,7 @@ int MWindowGUI::keypress_event()
 		result = 1;
 		break;
 
-	case 'k': case 'K':
+	case 'k': case 'K': 
 		if( alt_down() ) break;
 		stop_transport("MWindowGUI::keypress_event 2");
 		mwindow->nearest_plugin_keyframe(shift_down(),
diff --git a/cinelerra-5.1/guicast/bcwindowbase.C b/cinelerra-5.1/guicast/bcwindowbase.C
index 9f3e2123..93cdf15b 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.C
+++ b/cinelerra-5.1/guicast/bcwindowbase.C
@@ -274,7 +274,7 @@ int BC_WindowBase::initialize()
 	motion_events = 0;
 	resize_events = 0;
 	translation_events = 0;
-	ctrl_mask = shift_mask = alt_mask = 0;
+	ctrl_mask = shift_mask = alt_mask = winkey_mask = 0;
 	cursor_x = cursor_y = button_number = 0;
 	button_down = 0;
 	button_pressed = 0;
@@ -764,6 +764,7 @@ int BC_WindowBase::get_key_masks(unsigned int key_state)
 	ctrl_mask = (key_state & ControlMask) ? 1 : 0;  // ctrl key down
 	shift_mask = (key_state & ShiftMask) ? 1 : 0;   // shift key down
 	alt_mask = (key_state & Mod1Mask) ? 1 : 0;      // alt key down
+	winkey_mask = (key_state & Mod4Mask) ? 1 : 0;      // windows key down
 	return 0;
 }
 
@@ -4071,6 +4072,11 @@ int BC_WindowBase::ctrl_down()
 	return top_level->ctrl_mask;
 }
 
+int BC_WindowBase::winkey_down()
+{
+	return top_level->winkey_mask;
+}
+
 wchr_t* BC_WindowBase::get_wkeystring(int *length)
 {
 	if(length)
diff --git a/cinelerra-5.1/guicast/bcwindowbase.h b/cinelerra-5.1/guicast/bcwindowbase.h
index e4eb8ba4..c682d2cc 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.h
+++ b/cinelerra-5.1/guicast/bcwindowbase.h
@@ -347,6 +347,7 @@ public:
 	int alt_down();
 	int shift_down();
 	int ctrl_down();
+	int winkey_down();
 	int get_double_click();
 	int get_triple_click();
 // Bottom right corner
@@ -728,7 +729,7 @@ private:
 // key data
 	KeySym keysym;
 // Key masks
-	int ctrl_mask, shift_mask, alt_mask;
+	int ctrl_mask, shift_mask, alt_mask, winkey_mask;
 // Cursor motion information
 	int cursor_x, cursor_y;
 // Button status information
diff --git a/cinelerra-5.1/guicast/bcwindowbase.inc b/cinelerra-5.1/guicast/bcwindowbase.inc
index 046e7dd8..87bebace 100644
--- a/cinelerra-5.1/guicast/bcwindowbase.inc
+++ b/cinelerra-5.1/guicast/bcwindowbase.inc
@@ -27,7 +27,7 @@ class BC_WindowBase;
 class BC_WindowList;
 class Shuttle;
 
-#define BCTEXTLEN 1024
+#define BCTEXTLEN 1536
 #define BCSTRLEN 64
 #define KEYPRESSLEN 6
 // Milliseconds before cursor disappears during video playback
WINKEY.patch (3,531 bytes)
Andrew-R

Andrew-R

2020-11-28 00:45

reporter   ~0004378

I think this logic lives in mwindowgui.C
I tried

grep "case 'A'" cinelerra/*.C
cinelerra/dcraw.C: case 'A': FORC4 greybox[c] = atoi(argv[arg++]);
cinelerra/mwindowgui.C: case 'A':

guest@slax:/dev/shm/cinelerra/cinelerra-5.1$ grep "case 'a'" cinelerra/*.C
cinelerra/cwindow.C: case 'a': remote_control->gui->tile_windows(0); return 1;
cinelerra/dcraw.C: case 'a': use_auto_wb = 1; break;
cinelerra/filexml.C: case 'a': // &
cinelerra/mwindowgui.C: case 'a':
cinelerra/record.C: case 'a': // toggle mute audio

====
int MWindowGUI::keypress_event()
{
//printf("MWindowGUI::keypress_event 1 %d\n", get_keypress());
    int result = mbuttons->keypress_event();
    if( result ) return result;

    Track *this_track = 0, *first_track = 0;
    int packed = 0, overwrite = 0, plugins = 0;
    double position = 0;

    switch( get_keypress() ) {
    case 'A':
        if( !alt_down() && ctrl_down() ) {
            mwindow->edl->tracks->clear_selected_edits();
            draw_overlays(1);
            result = 1;
        }
        break;
    case 'a':
        if( !ctrl_down() && alt_down() ) {
            stop_transport("MWindowGUI::keypress_event 1");
            mwindow->nearest_auto_keyframe(shift_down(),
                !ctrl_down() ? PLAY_FORWARD : PLAY_REVERSE);
            result = 1;
        }
        else if( ctrl_down() && alt_down() ) {
            mwindow->select_edits(1);
            result = 1;
        }
        break;


So, *I think* this mean

for big A + ctrl (ctrl-shift-a ?) this clears selected edits.

for small a:
a + alt + shift : normal next nearest auto
+ ALSO ctrl = reverse nearset auto

and yes ctrl + alt + a = "select edits"

and "Select Edits (Ctrl+Alt+A) lives in
cinelerra/editpopup.C

EditPopupSelectEdits::EditPopupSelectEdits(MWindow *mwindow, EditPopup *popup)
 : BC_MenuItem(_("Select Edits"),_("Ctrl-Alt-a"),'a')
{
    this->mwindow = mwindow;
    this->popup = popup;
    set_ctrl(1);
    set_alt(1);
}

so, _probably_ you can just edit this editpopup.C for your first suggestion
IgorBeg

IgorBeg

2020-11-27 22:38

reporter   ~0004377

Unfortunately there is a shortcut conflict.
My suggestion could be in two different options:

1. Change the shortcut for Select Edits from "Select Edits (Ctrl+Alt+A)" to "Select Edits (Ctrl+Alt+')": Ctrl + Alt + single quote.
So Autos works as before:
Next auto 'Alt+A’ Move to next auto;
Prev auto 'Ctrl+Alt+A’ Move to previous auto;
Next auto select 'Alt+Shift+A’ Select from cursor to next auto;
Prev auto select 'Ctrl+Alt+Shift+A’ Select from cursor to previous auto.

2. If it is more important the "Ctrl+Alt+A" shortcut for Select Edits because there is" Ctrl+Shift+A" for Clear Select, then we can change the shortcuts for Next/Prev autos, and losing Next/Prev Auto Select:
Ctrl+Alt+Shift+RightArrow to Next auto;
Ctrl+Alt+Shift+LeftArrow to Prev auto.
I prefer this last one because for me it is more intuitive with the Arrows. And for Select between two autos we can use In and Out point or with two temporary labels.
RafaMar

RafaMar

2020-11-27 08:09

reporter   ~0004376

Wow, I'm sorry to have realized so late, is that for work reasons I have hardly been able to use Cinelerra, due to lack of time. But a few days ago I made some videos for a non-profit organization that spreads knowledge and I did them with Cinelerra and I noticed that the option to move or select with the keyboard using these shortcuts did not work. Thanks Phyllis.
PhyllisSmith

PhyllisSmith

2020-11-27 03:35

manager   ~0004375

Last edited: 2020-11-27 03:48

View 2 revisions

Will have to see when a change was made that impacted these 3 options as they no longer work.
It looks like sometime between June 2020 and September 2020, they quit working.

Issue History

Date Modified Username Field Change
2020-11-23 19:32 RafaMar New Issue
2020-11-27 03:35 PhyllisSmith Assigned To => PhyllisSmith
2020-11-27 03:35 PhyllisSmith Status new => confirmed
2020-11-27 03:35 PhyllisSmith Note Added: 0004375
2020-11-27 03:48 PhyllisSmith Note Edited: 0004375 View Revisions
2020-11-27 08:09 RafaMar Note Added: 0004376
2020-11-27 22:38 IgorBeg Note Added: 0004377
2020-11-28 00:45 Andrew-R Note Added: 0004378
2020-11-28 07:52 Andrew-R File Added: WINKEY.patch
2020-11-28 07:52 Andrew-R Note Added: 0004380
2020-11-28 07:58 Andrew-R File Added: WINKEY-2.patch
2020-11-28 07:58 Andrew-R Note Added: 0004381
2020-11-28 08:00 RafaMar Note Added: 0004382
2020-11-28 10:35 Andrew-R File Added: WINKEY-3.patch
2020-11-28 10:35 Andrew-R Note Added: 0004384
2020-11-28 11:05 RafaMar Note Added: 0004385
2020-11-28 12:29 Andrew-R Note Added: 0004386
2020-11-28 17:23 Andrew-R Note Added: 0004388
2020-11-29 20:38 PhyllisSmith Status confirmed => acknowledged
2020-11-29 20:38 PhyllisSmith Note Added: 0004391
2020-11-30 01:07 Andrew-R Note Added: 0004392
2020-11-30 13:02 IgorBeg Note Added: 0004393
2020-11-30 14:32 RafaMar File Added: Navigate window small.png
2020-11-30 14:32 RafaMar Note Added: 0004394
2020-11-30 14:46 RafaMar Note Added: 0004395
2020-11-30 16:19 Andrea_Paz Note Added: 0004396
2020-11-30 17:45 RafaMar Note Added: 0004397
2020-12-01 12:47 IgorBeg File Added: Cinelerra_JumpAndInsertKeyframes_byOverlayWindow_01.png
2020-12-01 12:47 IgorBeg Note Added: 0004398
2020-12-01 13:13 RafaMar Note Added: 0004399
2021-01-19 17:29 RafaMar Note Added: 0004551
2021-01-22 03:30 PhyllisSmith Status acknowledged => resolved
2021-01-22 03:30 PhyllisSmith Resolution open => fixed
2021-01-22 03:30 PhyllisSmith Note Added: 0004560
2021-01-27 19:10 PhyllisSmith Status resolved => closed
2021-01-27 19:10 PhyllisSmith Note Added: 0004602