0000549: Error in the first use of the batch render window with the FFMPEG and the default extension .mp4

ID	Project	Category	View Status	Date Submitted	Last Update

0000549	Cinelerra-GG	[All Projects] Bug	public	2021-01-20 06:28	2021-02-05 20:48

Reporter	RafaMar	Assigned To	PhyllisSmith
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Platform	PC	OS	Linux Mint	OS Version	19.3
Product Version
Target Version		Fixed in Version

Summary	0000549: Error in the first use of the batch render window with the FFMPEG and the default extension .mp4
Description	I want report an error that I have been observing from the beginning with the batch render window. This error was already present in the 2020-08 version and is still present in the 2021-01-19 build. This error only occurs on the first use of this wizard and has to do with assigning the extension when choosing FFMPEG. To play it you need to delete or rename, the .bcast5 folder, to simulate that it is the first time we use Cinelerra. And create a new list of EDL's to render, since if we load a list already created, this problem is not reproduced. Let's see if I can explain it so that it is understood. - When we open the Render window for the first time in "File format" it comes as "Unknown". - If I create a new render line, assigning an EDL and an output path, if I choose the FFMPEG option, this option automatically gives me the mp4 extension, and this is precisely the one I want to use and I don't touch anything else. - But when I press the Start button I get an error message with two windows, one says like this: "Couldn't open <file path> file.mp4" And a log message that says like this: "int FFMPEG :: init_encoder (const char *): bat file format: <file path> file.mp4 " How is it solved? Apparently it is not enough that in File format put FFMPEG, I must also click on choose extension, even if I want to use the same one that is shown, which is mp4 by default. If I display the extensions menu and click on another, or even on mp4, this problem no longer occurs.
Steps To Reproduce	Cinelerra GG has just been installed on a system or user who uses it for the first time, when making a batch render list for the first time also, do not take the precaution of clicking on the extension, even if you want to use the one that comes by default when you choose FFMPEG what is .mp4
Additional Information	Conclusions. - If the person who performs a batch render for the first time and wants to export with mp4 will encounter this problem. It will not be the case if, for example, this person chooses another format. Possible solutions. - The sloppy proposal by a person who does not know programming, that is me. Set by default an extension that no one wants to use today, such as .avi, which is also the first on the list. - The elegant one, fix this or failing that, when FFMPEG is chosen, the extension is left blank and forces the user to choose one. With this simplicity, this error no longer occurs. Even with the experience I have, I got a little confused with this, because I wanted to use mp4 and this was the extension that I saw and I did not realize that I should display this menu and click on it, and this problem repeats itself every time I do tests, because I always rename the .bcast5 folder first to simulate a first use of Cinelerra that is not contaminated with my settings, which I recover again after testing. I apologize for being such a perfectionist about these things, "fussy" I would say.
Tags	No tags attached.

PhyllisSmith 2021-02-05 20:48 manager ~0004616	Looks good from GIT build.

PhyllisSmith 2021-01-30 23:17 manager ~0004611	Thanks to RafaMar for feedback on problems and especially for Andrew's quick fix.

RafaMar 2021-01-28 20:02 reporter ~0004605	Ok @PhyllisSmith now I add these suggestions in BT 548.

PhyllisSmith 2021-01-28 15:59 manager ~0004604 Last edited: 2021-01-28 16:01 View 2 revisions	@Andrew-R Thank you again. The patch has been checked into GIT. @RafaMar BT 548 is already open for improving Batch Render so instead of opening a new one as I mentioned in the last Note, it would probably be better to add to that instead. Thank you.

PhyllisSmith 2021-01-28 00:06 manager ~0004603	@Andrew-R formattools_fix.diff mod works great and was a great idea. Will check into GIT next time I turn on the main computer. Thank you. @RafaMar Please open a new BT ticket for other Batch Render suggested changes -- it does not mean they will be feasible or do-able but it is best to have them logged on record so they do not get lost. I think both of the changes will be difficult and there may be other ways to implement them satisfactorily. The 2 changes to add in the same BT are "playhead positioning" and "adding someway to hook a a pdf how to" + anything else I might have mixed. That way I can close this one. As you can see there are a lot of really good requests logged but not enough programmer time available and because it is voluntary, developers are best at working on the ones that interest them.

RafaMar 2021-01-23 17:03 reporter ~0004588	Ok @Anrew-R , If @PhyllisSmith agrees to add these new options, we can open a new ticket for this new feature.

Andrew-R 2021-01-23 15:23 reporter ~0004587	@RafaMar can we leave additions to GUI in batchrender to some other bug(s)? I remember what you said, making those changes should be technically possible, I just need some time to type them in .. and test!. :/

RafaMar 2021-01-23 14:02 reporter ~0004581	Sorry, I misspelled the name of @PhyllisSmith in my previous comment.

RafaMar 2021-01-23 13:57 reporter ~0004580	@PhylliSmith @Andrew-R Another option that would be very useful in this wizard, even always visible, is to be able to choose whether the position of the playback cursor (insertion point) is to be taken into account or No, this could be a checkbox. I think that as it is now, many users will see it as an error, so this is the first thing I mentioned in my quick use guide.

RafaMar 2021-01-23 11:44 reporter ~0004576	Hello @Andrew-R, I apologize, yesterday I was unable to test due to work reasons. I have just tested the solution and IT WORKS PERFECT, both with the default option, that is mp4, and with any other format you choose, be it FFMPEG or another codec. Thank you very much for your work, this reminds me that I must update my wizard's starting guide, because this annoying error no longer exists thanks to your good work.

Andrew-R 2021-01-22 12:04 reporter ~0004569	@RafaMar try this patch? Please also try normal render, and different ffmpeg and non-ffmpeg types of output ...if possible ...... formattools_fix.diff (504 bytes) diff --git a/cinelerra-5.1/cinelerra/formattools.C b/cinelerra-5.1/cinelerra/formattools.C index 643655e3..68dd6afd 100644 --- a/cinelerra-5.1/cinelerra/formattools.C +++ b/cinelerra-5.1/cinelerra/formattools.C @@ -129,6 +129,9 @@ void FormatTools::create_objects( this->prompt_video_compression = prompt_video_compression; this->file_per_label = file_per_label; + + if(asset->format == FILE_UNKNOWN) + asset->format = FILE_FFMPEG; //printf("FormatTools::create_objects 1\n"); if(!recording) formattools_fix.diff (504 bytes)

RafaMar 2021-01-20 06:28 reporter	b.render.error.png (59,708 bytes) b.render.error.png (59,708 bytes)

Date Modified	Username	Field	Change
2021-01-20 06:28	RafaMar	New Issue
2021-01-20 06:28	RafaMar	File Added: b.render.error.png
2021-01-22 12:04	Andrew-R	File Added: formattools_fix.diff
2021-01-22 12:04	Andrew-R	Note Added: 0004569
2021-01-23 11:44	RafaMar	Note Added: 0004576
2021-01-23 13:57	RafaMar	Note Added: 0004580
2021-01-23 14:02	RafaMar	Note Added: 0004581
2021-01-23 15:23	Andrew-R	Note Added: 0004587
2021-01-23 17:03	RafaMar	Note Added: 0004588
2021-01-28 00:06	PhyllisSmith	Note Added: 0004603
2021-01-28 00:06	PhyllisSmith	Assigned To	=> PhyllisSmith
2021-01-28 00:06	PhyllisSmith	Status	new => acknowledged
2021-01-28 15:59	PhyllisSmith	Note Added: 0004604
2021-01-28 16:01	PhyllisSmith	Note Edited: 0004604	View Revisions
2021-01-28 20:02	RafaMar	Note Added: 0004605
2021-01-30 23:17	PhyllisSmith	Status	acknowledged => resolved
2021-01-30 23:17	PhyllisSmith	Resolution	open => fixed
2021-01-30 23:17	PhyllisSmith	Note Added: 0004611
2021-02-05 20:48	PhyllisSmith	Status	resolved => closed
2021-02-05 20:48	PhyllisSmith	Note Added: 0004616

View Issue Details

Activities

Issue History