View Issue Details

IDProjectCategoryView StatusLast Update
0000237Cinelerra-GG[All Projects] Featurepublic2019-11-10 08:35
ReporterOlaf Assigned Togoodguy  
PrioritynormalSeveritytweakReproducibilityalways
Status assignedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0000237: Adjustable background color of the compositor
DescriptionCompositor background is black and the color cannot be adjusted. This is not helpful if you want to crop videos with black borders, for example. In general, a clear colour separation of window area and video is only an advantage. Setting the background is one of the basic features, even Kdenlive can do it.
TagsCompositor

Activities

Olaf

Olaf

2019-11-10 08:35

reporter   ~0002452

If everyone who has to edit their videos with CGG sees it that way, then there is no alternative.

PhyllisSmith

PhyllisSmith

2019-11-09 18:47

manager   ~0002450

I think this is the description of the only outstanding issue which we are fixing by adjusting the frame location to never lie on the still image. Just to refresh from Note 2006: " ... In the meantime I put the bright frame up for discussion, which lies on the edges of the picture, thus covering it and preventing exact working in the edge area. Is this frame necessary for the still image ... (? Should the frame, if still necessary at all, not border the still image instead of lying on it?"

AND Note 2048: "No matter on which solution one agrees, nothing should be allowed to lie on the video itself. Holy ground, highlander!"

We have a mod to ensure that the bright frame no longer lies on the image and the 'Holy ground, highlander' is protected and it will be checked into GIT in a day or 2.

It turns out that this frame dates back to the original code in the HV version. At about line 2540 of cwindowgui.C is:

// Always draw output rectangle
                float x1, y1, x2, y2;
                x1 = 0;
                x2 = mwindow->edl->session->output_w;
                y1 = 0;
                y2 = mwindow->edl->session->output_h;
                output_to_canvas(mwindow->edl, 0, x1, y1);
                output_to_canvas(mwindow->edl, 0, x2, y2);

                get_canvas()->set_inverse();
                get_canvas()->set_color(WHITE);

                get_canvas()->draw_rectangle((int)x1,
                                (int)y1,
                                (int)(x2 - x1),
                                (int)(y2 - y1));

                get_canvas()->set_opaque();
        }

This drawn line is a good idea and makes it real obvious where the project's boundary really is, based on the session format, so it is easy to see what will actually be rendered in the final video. In other words, yes, it is necessary from my point of view and will remain.
Olaf

Olaf

2019-11-08 08:45

reporter   ~0002441

@PhyllisSmith: "but you only see it when you zoom in."

This may be because the majority of CGG users follow you and set the Composer Zoom to Auto. In all other settings, the bounding box is displayed without having to load a video or zebra. (By the way, in that form this would be a bug in auto-zoom, because the frame is not displayed there, isn't it?)

Here is a video from the year 2010 which only shows that this boinding box was always there: https://www.youtube.com/watch?v=zag7g6GdHJE

Bb.png (44,145 bytes)
Bb.png (44,145 bytes)
PhyllisSmith

PhyllisSmith

2019-11-08 02:30

manager   ~0002438

@Olaf
OK, I had to dig up a PAL file 720x576 and can see the white boundary now. but you only see it when you zoom in. I do not know where it comes from but will attempt to figure it out tomorrow.
PhyllisSmith

PhyllisSmith

2019-11-08 02:11

manager   ~0002437

Well, the fixes that got checked in and the explanation about fractional pixels is still relevant and needed to be done.

@Olaf
"background color of the canvas used ... is the same as the color of the bounding box, so it is no longer visible in the video." So I have attached a file using purple instead and there is no white boundary. You can see I have it zoomed in as much as I can and have shown just the right most bottom corner. So far no matter which video I load, I can not see a white boundary but there is a surrounding box that may be the exact size of what you are loading. I will try that next but I ran out of time today. More later.

purple_zebra.png (33,584 bytes)
purple_zebra.png (33,584 bytes)
IgorBeg

IgorBeg

2019-11-07 20:10

reporter   ~0002415

Okay Olaf, I saw your photomontage, and I understood.
In your image seems that you loose (you can not see) a lot of pixels. I confirm that bounding box is on the video and by my test that boundary line is 1 pixel width, I think. Of Course, 1 pixel width is a “big” value if the size of the Compositor window is very little (with Zoom= Auto) because it hides more video information; usually, in my old Notebook the Compositor size is about 530x400 pixels.
I can not tell you that it is important for me like for you, but I can agree with you that the boundary line should not cover the video information.
In the Compositor I can see the differences on the video if I toggle between play and stop.
In the output render I don’t see lack of information.
Olaf

Olaf

2019-11-07 15:38

reporter   ~0002408

@IgorBeg
The whole thing has absolutely nothing to do with the protection areas for obsolete tube televisions. Please have a look at my photomontage again (https://www.cinelerra-gg.org/bugtracker/file_download.php?file_id=350&type=bug).

The bounding box is *on the video*, so it covers a part of the video in an inadmissible way. Even if this part seems to be small at a glimpse, you will see on closer inspection that the work in this area is not insignificantly complicated.

Usually, instead of the bounding box, the composer punches out the entire area of the video format, in this example 720x576. The color of the canvas is independent and can be determined by the user. No matter on which solution one agrees, nothing should be allowed to lie on the video itself. Holy ground, highlander! Something else are camera and projector, which bring their own frame to show size changes above the actual video area.
IgorBeg

IgorBeg

2019-11-07 13:17

reporter   ~0002407

About #0002006 Olaf: “In the meantime I put the bright frame up for discussion, which lies on the edges of the picture, thus covering it and preventing exact working in the edge area.”

If I understand correctly Olaf’s request, I think that He would like to hide the boundary, of white colour, around the video/image (Project format’s boundary) in Compositor and showed it only when the “Show safe regions (F10)” tool is enabled. So You can see the three boundary: the boundary of the Project format and the two boundary of the safe regions.
And using the “Composer BG color”, in Preferences, to set a different background color as a “boundary” for the video frame.
Olaf, can you confirm or less, please?
Olaf

Olaf

2019-11-07 10:59

reporter   ~0002406

Because of the time difference, I'm going to cut this short. Besides the matter of course, I had already expressly agreed to answer any questions that arose.

The reference to and use of my photomontage in the video (0000237:0002400) can give the impression that the user has caused the problem himself.

The background color of the canvas used by PhyllisSmith in the video is the same as the color of the bounding box, so it is no longer visible in the video.

So geht das nicht. Topic missed. EOD.
Olaf

Olaf

2019-11-07 08:09

reporter   ~0002402

I don't understand the connection to the 720x576 (576/25p, DVD PAL) video I showed, @PhyllisSmith 0000237:0002400.
PhyllisSmith

PhyllisSmith

2019-11-07 01:04

manager   ~0002400

GIT checkin fixes the background switching to black when using the OpenGL driver. Another improvement was checked in that fixes the "flash" that occurred in a couple of different places when you restart playing after having stopped.

And now for the elephant in the room! The boundary problem is due to a "fractional pixel" which is a result of odd dimensions (odd dimensions meaning in this case, not divisible by 2). For example, when media that is 1303 x 1017 (an example is the webp video in note 2391) is loaded - i.e. not even numbers. the session takes on those dimensions. So, using the OpenGL driver, this fractional pixel appears as a boundary on the bottom in the Compositor. CinGG does not like these odd dimensions and in fact when you load the above video, you get the error message of:

 "/root/Downloads/0000237...of the compositor.webp's rersolution is 1303x1017.
    Images with odd dimensions may not decode properly."

In the case of using the X11 driver, this oddity results in a fractional pixel border on all 4 sides as opposed to just the bottom as in the OpenGL driver. You should make a note of the fact that if you create a New project or try to change Format dimensions in that menu to odd numbers, the program changes them to even. There is a very good reason for this to avoid these types of problems.

Here is the way to get past the OpenGL bottom boundary problem. Bring up the camera in the Compositor and change the Y coordinate to 0.500 to compensate for the fractional pixel that resulted from odd dimensions. In the case of using the X11 video driver, add 0.50 to both the Y and X coordinate.

A demo illustrating that if you use even numbered dimensions format (zebra.jpg), it works as expected is at:
    https://streamable.com/at6rz
The first part of the demo shows background color is working as expected. The second half shows the ERROR MESSAGE when odd dimensions are loaded warning of potential problems and you see the boundary. It also shows how you can work with this.
PhyllisSmith

PhyllisSmith

2019-11-06 15:05

manager   ~0002397

Short update -- a fix for the confirmed playback OpenGL problem was generated yesterday and I am still testing. I now see the boundary problem and hope that too can be addressed.
Olaf

Olaf

2019-11-04 18:38

reporter   ~0002391

A screenshot for clarification. (Here you can also see that the frame is frayed in several places, which makes editing unnecessarily difficult.)

If you have any questions, please ask, unfortunately I can't read thoughts.

Thank you both for your cooperation!

0000237: Adjustable background color of the compositor.webp (493,698 bytes)
PhyllisSmith

PhyllisSmith

2019-11-04 16:32

manager   ~0002390

OK !! now I have something very specific to address. I was using the X11 Video Driver instead of X11-OpenGL so now I see the problem and we can try to figure it out.

Quote from Note 2006: "you can see for yourself what's lacking. ... In the meantime I put the bright frame up for discussion, which lies on the edges of the picture, thus covering it and preventing exact working in the edge area.
Is this frame necessary for the still image (without switched on tools like camera, projector or cutting)?
Should the frame, if still necessary at all, not border the still image instead of lying on it?"

I STILL DO NOT UNDERSTAND the above so that is why I have nothing to show GG for him to work on.
Andrea_Paz

Andrea_Paz

2019-11-04 11:23

updater   ~0002389

I confirm the bug.
Olaf

Olaf

2019-11-04 09:58

reporter   ~0002388

Probably I am the only one who uses this function, otherwise there would have been complaints in the meantime.

If you are bored you can try the following: You set the "Composer BG Color" to 006a00ae, load a video and watch the result. Then you play the video and watch the result. If the background of the canvas is identical in both cases (color: 006a00ae) then this request is considered done. If, however, the background switches to "black" when playing and is only "purple" when standing, a check of the previous work would be advisable. In both cases I ask for a short feedback.
Olaf

Olaf

2019-09-28 12:38

reporter   ~0002189

<blockquote>
There is still more work to do to verify all 90 some places where vframe is being used, so do not hesitate to report missed spots or bugs as it will move things along a lot faster to an acceptable conclusion.
</blockquote>
So, the month is over, the next release is just around the corner and I don't see any progress. (Even today I can't see why the monochrome background color of the canvas (previously black!) has to be redrawn in more than 90 different places instead of calling one function.)
PhyllisSmith

PhyllisSmith

2019-08-28 19:35

manager   ~0002048

The 3 week, i.e. 20 days, was used for development as explained in
   https://www.mail-archive.com/[email protected]/msg00449.html

On Tue, 27 Aug 2019 21:33:19 a fix for "the buttons are shifted, one is almost covered" was checked in:
   "fix render progress booby, add batchrender warn for zero length, click to play layout fix, dav1d meson build fixes"
I was wrong because I thought that the button that was almost covered was due to the mods made while working on the background color for the Compositor (I am frequently wrong!). End result was that since it did not involve background color, it did not involve the frame issue.

OK to withdraw the question, but I am still going to look into it anyway.
Olaf

Olaf

2019-08-28 09:06

reporter   ~0002047

Hm…*

As for the frame question, nobody's interested but me. I withdraw the question.

--
 * the general development was resumed after 20 days, according to git. av1, mask and ffmpeg. not the background.
PhyllisSmith

PhyllisSmith

2019-08-27 14:16

manager   ~0002043

Today gg is working on "the buttons are shifted, one is almost covered" since Sam informed us that the "Click to Play" button is obscured and I totally missed this and my eyes could not see which button was covered (bad eyes and I did not look in the right places). Hopefully that will better illustrate the detected problem with the frame/image area.
Olaf

Olaf

2019-08-27 11:01

reporter   ~0002040

One question, is the development complete or is it still going on?
Olaf

Olaf

2019-08-09 09:50

reporter   ~0002006

Good work so far in the short time! There is apparently still time to final completion, you can see for yourself what's lacking.

In the meantime I put the bright frame up for discussion, which lies on the edges of the picture, thus covering it and preventing exact working in the edge area.
Is this frame necessary for the still image (without switched on tools like camera, projector or cutting)?
Should the frame, if still necessary at all, not border the still image instead of lying on it?
PhyllisSmith

PhyllisSmith

2019-08-05 01:09

manager   ~0001999

Last edited: 2019-08-05 01:12

View 2 revisions

The latest GIT checkin includes changing the Compositor Canvas background color also. There is still more work to do to verify all 90 some places where vframe is being used, so do not hesitate to report missed spots or bugs as it will move things along a lot faster to an acceptable conclusion. The Canvas, as always, does not get rendered (at least not in my cases).

Olaf

Olaf

2019-07-31 09:33

reporter   ~0001996

Thx PhyllisSmith! Here's the corrected description of the feature request that didn't seem to do justice to the summary of the request before, see above, changes and priority highlighted with asterisks:

Compositor background *complete with the so-called Canvas* is black and the color cannot be adjusted. This is not helpful if you want to crop videos with black borders, for example. In general, *a clear colour separation of window area (Canvas) and video is only an advantage*. Setting the background *- especially the canvas -* is one of the basic features, even Kdenlive can do it.

I apologize for my linguistic inadequacies and the additional work that may result from them.
PhyllisSmith

PhyllisSmith

2019-07-30 20:01

manager   ~0001995

The black area of the Compositor that exceeds the project dimensions is the Canvas -- it is part of the Pixmap -- and is not rendered.

A error similar to what IgorB demo-ed is being fixed, but of course there could be more.
Olaf

Olaf

2019-07-30 12:43

reporter   ~0001994

Learning question: What do you call the (black) area of the Compositor that exceeds the project dimensions?

In addition, the buttons are shifted, one is almost covered.

babel.png (300,641 bytes)
IgorBeg

IgorBeg

2019-07-30 12:01

reporter   ~0001992

I only did a few quickly tests with Cin-Ub16-20190730.
IMHO for the monthly builds I would use the 20190724 version because it is more tested.
Further tests are required for the latest invasive mod. Sorry.

Take a look please:
https://streamable.com/pxqcx
PhyllisSmith

PhyllisSmith

2019-07-29 17:44

manager   ~0001990

A mod has been checked into GIT to include this feature. I hope it covers what is expected, but am not sure. A Ubuntu 16 build is at: https://www.cinelerra-gg.org/download/testing/cinelerra-5.1-ub16-x86_64-static.txz

A demo is provided of how to use it at: https://streamable.com/no6oz

Testing is appreciated because the monthly builds will be coming up on Wednesday AND because there were about 90 places in the code that are affected by "clear vframe".
Sam

Sam

2019-07-24 11:16

administrator   ~0001981

I would wish for my own alignment lines. PP has such a feature that is very handy when you want to align objects like text or even your own images that I want to show.
https://streamable.com/l460f
Sam

Sam

2019-07-24 10:51

administrator   ~0001980

Last edited: 2019-07-24 10:52

View 2 revisions

1) Any suggestions of where to pick this color? Settings->Preferences, Appearance by "Highlighting Inversion Color" and then you always have that?

A good choice, at this point it fits and the setting can be changed at any time like anything else that is adjustable there. It would also be advantageous if the selected color is immediately visible, even without restarting.
--> I agree with Olaf.

2) Or does it have to be Session based?

With very few exceptions, I see no reason for this, so no, see also answer above.
--> same here.

3) Will you want the Color Picker involved?

I want to be able to determine a color that is clearly different from the video image, so that it can be captured by the eye in size and position at any time without tools such as superimposed frames. If the Color Picker can help and the user is no longer dependent on external programs such as kcolorchooser then yes. (Sorry Igor, very few users can remember the RGB colour code.)
--> I would prefer a Color Picker

4) Should there be another tool added to the Compositor window?

I'm not sure I understand the question correctly. Does this mean something like what is described under no. 0000238?

Something like that in Kdenlive:
https://streamable.com/a338p

or like my photomontage:

I find the solution via the FFmpeg "law of thirds" plugin too cumbersome.



Overlay-lines_03.jpg (136,889 bytes)
Overlay-lines_03.jpg (136,889 bytes)
Olaf

Olaf

2019-07-24 08:44

reporter   ~0001979

Hi Leute! I'm happy for the project that the request has found a hearing.

1) Any suggestions of where to pick this color? Settings->Preferences, Appearance by "Highlighting Inversion Color" and then you always have that?

A good choice, at this point it fits and the setting can be changed at any time like anything else that is adjustable there. It would also be advantageous if the selected color is immediately visible, even without restarting.

2) Or does it have to be Session based?

With very few exceptions, I see no reason for this, so no, see also answer above.

3) Will you want the Color Picker involved?

I want to be able to determine a color that is clearly different from the video image, so that it can be captured by the eye in size and position at any time without tools such as superimposed frames. If the Color Picker can help and the user is no longer dependent on external programs such as kcolorchooser then yes. (Sorry Igor, very few users can remember the RGB colour code.)

4) Should there be another tool added to the Compositor window?

I'm not sure I understand the question correctly. Does this mean something like what is described under no. 0000238?
IgorBeg

IgorBeg

2019-07-24 07:57

reporter   ~0001978

Waiting for Olaf… (and the others)

IMHO I prefer this option (like 0000247) were in Preferences>Appearance: a new option, for example “Background color for Compositor” and you always have that, until you change again.
Default is #000000 (black), of course. And I would not use color picker but only “rrggbb” code like it is in "Highlighting Inversion Color".
PhyllisSmith

PhyllisSmith

2019-07-24 01:24

manager   ~0001975

Any suggestions of where to pick this color?
- Settings->Preferences, Appearance by "Highlighting Inversion Color" and then you always have that?
- Or does it have to be Session based?
- Will you want the Color Picker involved?
- Should there be another tool added to the Compositor window?

Issue History

Date Modified Username Field Change
2019-06-04 11:19 Olaf New Issue
2019-06-04 11:19 Olaf Tag Attached: Compositor
2019-07-24 01:24 PhyllisSmith Note Added: 0001975
2019-07-24 07:57 IgorBeg Note Added: 0001978
2019-07-24 08:44 Olaf Note Added: 0001979
2019-07-24 10:51 Sam File Added: Overlay-lines_03.jpg
2019-07-24 10:51 Sam Note Added: 0001980
2019-07-24 10:52 Sam Note Edited: 0001980 View Revisions
2019-07-24 11:16 Sam Note Added: 0001981
2019-07-29 17:44 PhyllisSmith Note Added: 0001990
2019-07-30 03:26 PhyllisSmith Assigned To => goodguy
2019-07-30 03:26 PhyllisSmith Status new => assigned
2019-07-30 12:01 IgorBeg Note Added: 0001992
2019-07-30 12:43 Olaf File Added: babel.png
2019-07-30 12:43 Olaf Note Added: 0001994
2019-07-30 20:01 PhyllisSmith Note Added: 0001995
2019-07-31 09:33 Olaf Note Added: 0001996
2019-08-05 01:09 PhyllisSmith Note Added: 0001999
2019-08-05 01:12 PhyllisSmith Note Edited: 0001999 View Revisions
2019-08-09 09:50 Olaf Note Added: 0002006
2019-08-27 11:01 Olaf Note Added: 0002040
2019-08-27 14:16 PhyllisSmith Note Added: 0002043
2019-08-28 09:06 Olaf Note Added: 0002047
2019-08-28 19:35 PhyllisSmith Note Added: 0002048
2019-09-28 12:38 Olaf Note Added: 0002189
2019-11-04 09:58 Olaf Note Added: 0002388
2019-11-04 11:23 Andrea_Paz Note Added: 0002389
2019-11-04 16:32 PhyllisSmith Note Added: 0002390
2019-11-04 18:38 Olaf File Added: 0000237: Adjustable background color of the compositor.webp
2019-11-04 18:38 Olaf Note Added: 0002391
2019-11-06 15:05 PhyllisSmith Note Added: 0002397
2019-11-07 01:04 PhyllisSmith Note Added: 0002400
2019-11-07 08:09 Olaf Note Added: 0002402
2019-11-07 10:59 Olaf Note Added: 0002406
2019-11-07 13:17 IgorBeg Note Added: 0002407
2019-11-07 15:38 Olaf Note Added: 0002408
2019-11-07 20:10 IgorBeg Note Added: 0002415
2019-11-08 02:11 PhyllisSmith File Added: purple_zebra.png
2019-11-08 02:11 PhyllisSmith Note Added: 0002437
2019-11-08 02:30 PhyllisSmith Note Added: 0002438
2019-11-08 08:45 Olaf File Added: Bb.png
2019-11-08 08:45 Olaf Note Added: 0002441
2019-11-09 18:47 PhyllisSmith Note Added: 0002450
2019-11-10 08:35 Olaf File Added: Composer-default_wo_video.png
2019-11-10 08:35 Olaf Note Added: 0002452