View Revisions: Issue #59
| Summary | 0000059: Packaging: Issues identified in source tree / build process | ||
|---|---|---|---|
| Revision | 2018-12-14 00:33 by administrator | ||
| Description | The review process for Cinelerra-GG's inclusion in RPMfusion continues apace (see package review bug): https://bugzilla.rpmfusion.org/show_bug.cgi?id=5093 Our always-diligent package reviewers have identified a number of issues, most relatively minor, that we've had to work around in packaging the software to meet Fedora guidelines. Policy is that we also bring these issues to the attention of the upstream project, so here I am. (1) The text of the GPL in cinelerra-5.1/COPYING is out of date, and uses an out of date street address for the FSF offices. (2) The application's .desktop file template at cinelerra-5.1/image/cin.desktop is outdated, and does not follow the current Freedesktop specification: http://freedesktop.org/wiki/Specifications/desktop-entry-spec The following errors are produced by the desktop-file-validate tool: $ desktop-file-validate image/cin.desktop image/cin.desktop: warning: value "Application;AudioVideo;Multimedia;VideoEditing;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" image/cin.desktop: error: value "Application;AudioVideo;Multimedia;VideoEditing;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Multimedia"; values extending the format should start with "X-" image/cin.desktop: error: value "Application;AudioVideo;Multimedia;VideoEditing;" for key "Categories" in group "Desktop Entry" contains an unregistered value "VideoEditing"; values extending the format should start with "X-" image/cin.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated image/cin.desktop: error: (will be fatal in the future): value "cin.svg" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path (3) Many installed files have their executable bits set unnecessarily. (4) Certain files are built with executable stack, a dangerous code practice which is normally not necessary and merely the result of an oversight in development. Thanks very much, as I said I'll report 0000003 separately (I have patches to fix it), and I think that should be about it for now. |
||
| Revision | 2018-12-13 22:01 by ferdnyc | ||
| Description | The review process for Cinelerra-GG's inclusion in RPMfusion continues apace (see package review bug): https://bugzilla.rpmfusion.org/show_bug.cgi?id=5093 Our always-diligent package reviewers have identified a number of issues, most relatively minor, that we've had to work around in packaging the software to meet Fedora guidelines. Policy is that we also bring these issues to the attention of the upstream project, so here I am. 0000001. The text of the GPL in cinelerra-5.1/COPYING is out of date, and uses an out of date street address for the FSF offices. 0000002. The application's .desktop file template at cinelerra-5.1/image/cin.desktop is outdated, and does not follow the current Freedesktop specification: http://freedesktop.org/wiki/Specifications/desktop-entry-spec The following errors are produced by the desktop-file-validate tool: $ desktop-file-validate image/cin.desktop image/cin.desktop: warning: value "Application;AudioVideo;Multimedia;VideoEditing;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" image/cin.desktop: error: value "Application;AudioVideo;Multimedia;VideoEditing;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Multimedia"; values extending the format should start with "X-" image/cin.desktop: error: value "Application;AudioVideo;Multimedia;VideoEditing;" for key "Categories" in group "Desktop Entry" contains an unregistered value "VideoEditing"; values extending the format should start with "X-" image/cin.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated image/cin.desktop: error: (will be fatal in the future): value "cin.svg" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path 0000003. Many installed files have their executable bits set unnecessarily. #4. Certain files are built with executable stack, a dangerous code practice which is normally not necessary and merely the result of an oversight in development. Thanks very much, as I said I'll report 0000003 separately (I have patches to fix it), and I think that should be about it for now. |
||
